Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Treat deprecated/experimental members as documented #88401

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Feb 16, 2024

@dalexeev dalexeev added this to the 4.3 milestone Feb 16, 2024
@dalexeev dalexeev requested a review from a team as a code owner February 16, 2024 14:22
@Mickeon
Copy link
Contributor

Mickeon commented Feb 16, 2024

I do enjoy the codestyle changes in EditorHelp a lot, despite the fact that I'm going to be very miserable later because they conflict with a PR I have yet to publish because I forgot to.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at it again. This is good and great.

In my opinion it would be nice if only one newline was used (instead of two) for deprecated things, just to shorten how much space these messages occupy when a description ACTUALLY exists (I'm working on it). But it's very opinionated indeed.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me at a glance.

It makes sense to ignore deprecated/experimental members in the completion percentage too.

@akien-mga akien-mga merged commit 0a89888 into godotengine:master Feb 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the doc-deprecated-experimental-as-documented branch February 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants